Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Lee Jones]

On Tue, 01 Nov 2016, Johan Hovold wrote:

> Make sure to drop the reference taken by bus_find_device_by_name()
> before returning from mfd_clone_cell().
> 
> Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
>  drivers/mfd/mfd-core.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 3ac486a597f3..c57e407020f1 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -399,6 +399,8 @@ int mfd_clone_cell(const char *cell, const char **clones, size_t n_clones)
>  					clones[i]);
>  	}
>  
> +	put_device(dev);
> +
>  	return 0;
>  }
>  EXPORT_SYMBOL(mfd_clone_cell);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog