Re: [RFC][PATCH 2/7] kref: Add kref_read()

From: Greg KH
Date: Tue Nov 15 2016 - 02:28:52 EST


On Mon, Nov 14, 2016 at 10:16:55AM -0800, Christoph Hellwig wrote:
> On Mon, Nov 14, 2016 at 06:39:48PM +0100, Peter Zijlstra wrote:
> > Since we need to change the implementation, stop exposing internals.
> >
> > Provide kref_read() to read the current reference count; typically
> > used for debug messages.
>
> Can we just provide a printk specifier for a kref value instead as
> that is the only valid use case for reading the value?

Yeah, that would be great as no one should be doing anything
logic-related based on the kref value.

thanks,

greg k-h