Re: [RFC][PATCH 0/7] kref improvements

From: Ingo Molnar
Date: Tue Nov 15 2016 - 02:42:57 EST



* Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Nov 14, 2016 at 06:39:46PM +0100, Peter Zijlstra wrote:
> > This series unfscks kref and then implements it in terms of refcount_t.
> >
> > x86_64-allyesconfig compile tested and boot tested with my regular config.
> >
> > refcount_t is as per the previous thread, it BUGs on over-/underflow and
> > saturates at UINT_MAX, such that if we ever overflow, we'll never free again.
> >
> >
>
> Thanks so much for doing these, at the very least, I want to take the
> kref-abuse-fixes now as those users shouldn't be doing those foolish
> things. Any objection for me taking some of them through my tree now?

Very nice series indeed!

We normally route atomics related patches through tip:locking/core (there's also
tip:atomic/core), but this is a special case I think, given how broadly it
interacts with driver code.

So both would work I think: we could concentrate these and only these patches into
tip:atomic/core into an append-only tree, or you can carry them in the driver tree
- whichever variant you prefer!

Thanks,

Ingo