Re: [PATCH v2 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument

From: Linus Walleij
Date: Tue Nov 15 2016 - 04:17:35 EST


On Fri, Nov 11, 2016 at 3:44 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote:

> According to pinconf-generic.h, the argument for
> PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled
> with a pull up/down resistor, zero if it is directly connected
> to VDD or ground.
>
> Since Allwinner hardware uses a weak pull resistor internally,
> the argument should be 1.
>
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>

Patch applied with Maxime's ACK.

Yours,
Linus Walleij