Re: [PATCH v4 2/2] Add support for OV5647 sensor

[Guenter Roeck]

On 11/15/2016 04:10 AM, Pavel Machek wrote:
> Hi!
>
> > Add support for OV5647 sensor.
>
> > +static int ov5647_write(struct v4l2_subdev *sd, u16 reg, u8 val)
> > +{
> > +	int ret;
> > +	unsigned char data[3] = { reg >> 8, reg & 0xff, val};
> > +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> > +
> > +	ret = i2c_master_send(client, data, 3);
> > +	if (ret != 3) {
> > +		dev_dbg(&client->dev, "%s: i2c write error, reg: %x\n",
> > +				__func__, reg);
> > +		return ret < 0 ? ret : -EIO;
> > +	}
> > +	return 0;
> > +}
>
> Sorry, this is wrong. It should something <0 any time error is detected.

It seems to me that it does return a value < 0 each time an error is detected.

Guenter