Re: [PATCH 10/11] hisi_sas: use atomic64_t for hisi_sas_device.running_req

From: Zhangfei Gao
Date: Tue Nov 15 2016 - 20:44:32 EST


On Mon, Nov 7, 2016 at 8:48 PM, John Garry <john.garry@xxxxxxxxxx> wrote:
> Sometimes the value of hisi_sas_device.running_req
> would go negative unless we have the check for
> running_req >= 0 before trying to decrement.
>
> This is because using running_req is not thread-safe.
>
> As such, the value for running_req may be actually incorrect,
> so use atomic64_t instead.
>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> Reviewed-by: Xiang Chen <chenxiang66@xxxxxxxxxxxxx>

Reviewed-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>