Re: [PATCH 0/4] DW DMAC: update device tree
From: Andy Shevchenko
Date: Wed Nov 16 2016 - 10:19:08 EST
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote:
> It wasn't possible to enable some features like
> memory-to-memory transfers or multi block transfers via DT.
> It is fixed by these patches.
> Â* Rename is_private to is-private as ordered by DT policy.
> Â(just for cleanup) The change leaves the support for theÂ
> Âold format.
> Â* Add is-memcpu property, so it is possible to
> Âenable memory-to-memory transfers support via DT.
> Â* Add hw-llp property, so it is possible to enable
> Âhardware multi block transfers support via DT.
> Â* Update DW DMAC device tree documentation.
I have few comments I posted. Besides that don't forget about current
users of the DT properties you standardized (by naming). Better you
convert them at the same time. Older DT (blobs) are being still
Otherwise looks okay after you address all my comments and maybe others
will do some. The DT people ACK is a must before this goes somewhere.
Also, please keep Cc list as small as possible. For example I'm not sure
Viresh has time to look at them, but he might keep an eye on the
dmaengine mailing list. Same about Dan.
> Eugeniy Paltsev (4):
> Â DW DMAC: rename is_private property as ordered by DT policy
> Â DW DMAC: add is-memcpu property to device tree
> Â DW DMAC: add hw-llp property to device tree
> Â Update device tree Synopsys DW DMAC documentation
> ÂDocumentation/devicetree/bindings/dma/snps-dma.txt | 10 ++++++++--
> Âdrivers/dma/dw/core.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âdrivers/dma/dw/platform.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 10 ++++++++++
> Âinclude/linux/platform_data/dma-dw.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ4 ++--
> Â4 files changed, 21 insertions(+), 5 deletions(-)
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy