Re: commit 0b5da8d: fuse: add support for SEEK_HOLE and SEEK_DATA in lseek

From: Ravishankar N
Date: Wed Nov 16 2016 - 20:34:37 EST


Hi Nikolaus,

On 11/17/2016 01:39 AM, Nikolaus Rath wrote:
Hi Ravishankar,

In commit 0b5da8d you added support for a new FUSE_LSEEK
operation. However, as far as I can tell the corresponding userspace
code never landed in libfuse.

Do you have a corresponding patch for libfuse?
No, unfortunately. I only used gluster to test what I wrote.

Looking at the commit message, I assume this functionality was added
specifically for glusterfs which presumably does not use libfuse.

You're right, gluster has its own code [1].
But
even in that case it would be nice if you could Cc
fuse-devel@xxxxxxxxxxxxxxxxxxxxx
The discussion[2] actually did start on fuse-devel.
so that someone else can add support
That would be great.
for this. This is important because AFAIR the libfuse documentation is
the only thing that comes close to an official documentation of the FUSE
API.


Best regards,
Ravi


[1] https://github.com/gluster/glusterfs/blob/master/xlators/mount/fuse/src/fuse-bridge.c
[2] https://sourceforge.net/p/fuse/mailman/message/34227449/
Best,
-Nikolaus