[PATCH] dumpstack: handle NULL stack pointer in show_trace_log_lvl()
From: Josh Poimboeuf
Date: Thu Nov 17 2016 - 01:05:49 EST
When show_trace_log_lvl() is called from show_regs(), it completely
fails to dump the stack. This bug was introduced when
show_stack_log_lvl() was removed with the following commit:
0ee1dd9f5e7e ("x86/dumpstack: Remove raw stack dump")
Previous callers of that function now call show_trace_log_lvl()
directly. That resulted in a subtle change, in that the 'stack'
argument can now be NULL in certain cases.
A NULL 'stack' pointer means that the stack dump should start from the
topmost stack frame unless 'regs' is valid, in which case it should
start from 'regs->sp'.
Fixes: 0ee1dd9f5e7e ("x86/dumpstack: Remove raw stack dump")
Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
arch/x86/kernel/dumpstack.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 499aa6f..1e057b0 100644
@@ -59,6 +59,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
printk("%sCall Trace:\n", log_lvl);
unwind_start(&state, task, regs, stack);
+ stack = stack ? : get_stack_pointer(task, regs);
* Iterate through the stacks, starting with the current stack pointer.