On Thu, Nov 17, 2016 at 06:44:55AM -0800, Guenter Roeck wrote:Good point.
On 11/17/2016 02:55 AM, Mark Rutland wrote:
On Wed, Nov 16, 2016 at 02:40:24PM -0800, Guenter Roeck wrote:
On Wed, Nov 16, 2016 at 08:27:09PM -0200, Fabio Estevam wrote:
On Wed, Nov 16, 2016 at 8:10 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
Anyway, I guess the problem is that the "official" dtb files no longer provide
the skeleton /chosen and /memory nodes (and maybe others), and qemu seems to
expect that they are provided. Is that correct ?
imx6qdl-sabrelite.dtsi provides chosen and memory nodes.
Yes, but not the 'device_type' property, which the kernel seems to expect.
Memory nodes require this property per ePAPR and the devicetree.org
spec, so the bug is that we didn't add those when removing the
The downside from qemu perspective is that the real hardware seems
to add the property unconditionally, or the boot failure would have
been seen there as well.
I submitted https://patchwork.ozlabs.org/patch/695951/; we'll see how it goes.
Sure, the firmare/bootlaoder you're using may add this automatically.
My worry is that adding this to a generic file in QEMU only serves to
mask this class of bug for other boards (i.e. they'll work fine in QEMU,
but not on real HW using whatever bootlaoder happens ot be there).