Re: [RFC PATCH] of: base: add support to get machine model name
From: Arnd Bergmann
Date: Thu Nov 17 2016 - 13:20:38 EST
On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote:
> Currently platforms/drivers needing to get the machine model name are
> replicating the same snippet of code. In some case, the OF reference
> counting is either missing or incorrect.
> This patch adds support to read the machine model name either using
> the "model" or the "compatible" property in the device tree root node.
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
I like the idea. One small comment:
> +int of_machine_get_model_name(const char **model)
> + int error;
> + struct device_node *root;
> + root = of_find_node_by_path("/");
> + if (!root)
> + return -EINVAL;
The global of_root variable points ot this already, and is defined
in the same file, so I think we can just skip the lookup.