Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

From: Sandy Harris
Date: Thu Nov 17 2016 - 20:07:15 EST


Add Ted T'so to cc list. Shouldn't he be included on anything affecting
the random(4) driver?

On Tue, Oct 18, 2016 at 8:34 AM, Corentin Labbe
<clabbe.montjoie@xxxxxxxxx> wrote:

> From: LABBE Corentin <clabbe.montjoie@xxxxxxxxx>
>
> The Security System have a PRNG.
> This patch add support for it as an hwrng.

Which is it? A PRNG & a HW RNG are quite different things.
It would, in general, be a fairly serious error to treat a PRNG
as a HWRNG.

If it is just a prng (which it appears to be from a quick look
at your code) then it is not clear it is useful since the
random(4) driver already has two PRNGs. It might be
but I cannot tell.