Re: [PATCH 1/2] of: base: add support to get machine model name

From: Sudeep Holla
Date: Fri Nov 18 2016 - 05:41:18 EST

On 17/11/16 21:00, Frank Rowand wrote:
On 11/17/16 07:32, Sudeep Holla wrote:
Currently platforms/drivers needing to get the machine model name are
replicating the same snippet of code. In some case, the OF reference
counting is either missing or incorrect.

This patch adds support to read the machine model name either using
the "model" or the "compatible" property in the device tree root node
to the core OF/DT code.

This can be used to remove all the duplicate code snippets doing exactly
same thing later.

I find five instances of reading only property "model":


Ah sorry you were not Cc-ed in 2/2, but that shows all the instances
that this will be used for.

I find one instance of reading property "model", then if
that does not exist, property "compatible":


Correct as you can check in patch 2/2

The proposed patch matches the code used in one place, and thus
current usage does not match the patch description.

Yes, but does it matter ? compatibles are somewhat informative about the
model IMO.

Is my search bad? Are you planning to add additional instances
of reading "model" then "compatible"?

No, just replacing the existing ones as in patch 2/2