Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

From: Zhangjian (Bamvor)
Date: Fri Nov 18 2016 - 08:00:00 EST

Hi, Michael

On 2016/11/18 18:31, Michael Ellerman wrote:
>Hi Bamvor,
>bamvor.zhangjian@xxxxxxxxxx writes:
>> From: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>
>> Currently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES to
>> indicate the default test program, extended test program and test files.
>> These lead to duplicated all and clean targets.
>> In order to remove them, introduce TEST_GEN_PROGS,
>> TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiled
>> objected.
>It's nice to be able to drop the clean rules, but renaming all those
>variables causes a lot of churn.
>I think it would be better if we add a new variable, maybe NO_CLEAN,
>which can be used to specify anything in TEST_PROGS/EXTENDED which
>should *not* be cleaned.
>And then the default clean rule will just do:
> $(RM) -fr $(filter-out $(NO_CLEAN),$(TEST_PROGS))
Maybe I lost somewhere. I add these variable for all and
clean target. They will be used to output the objects to OUTPUT
directory. Could you please explain in details how should I do it for
"all" target if I do not introduce TEST_GEN_PROGS,


>I think that would require less changes overall, because most tests just
>want to build some files, run them, and then clean them. The tests that
>need to do more elaborate things are the exception.