Re: [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names

From: Rob Herring
Date: Fri Nov 18 2016 - 09:23:52 EST


On Thu, Nov 17, 2016 at 03:59:19PM +0800, yuantian.tang@xxxxxxx wrote:
> From: Tang Yuantian <Yuantian.Tang@xxxxxxx>
>
> Added explanation for reg-names to make it more clear.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@xxxxxxx>
> ---
> Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> index fc33ca0..80cf10c 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> @@ -10,6 +10,8 @@ Required properties:
> Optional properties:
> - dma-coherent: Enable AHCI coherent DMA operation.
> - reg-names: register area names when there are more than 1 register area.
> + example: 'ahci' is for sata controller register.
> + 'sata-ecc' is for sata ecc register.

This is not an example, but should be exactly what names are used.

When is there more than one area? That should be defined by the
compatible string and spelled out here.

Rob