Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic

From: David Hildenbrand
Date: Fri Nov 18 2016 - 13:20:58 EST

Am 17.11.2016 um 15:55 schrieb Paolo Bonzini:
kvm_arch_set_irq is unused since commit b97e6de9c96. Merge
its functionality with kvm_arch_set_irq_inatomic.

Reported-by: Jiang Biao <jiang.biao2@xxxxxxxxxx>
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

As you said, it is unused. Therefore the functionality is superfluous. Why merge it?

We can still introduce this later if we ever need it. Or do you have a concrete user in mind?

The patch in general looks good to me. Just wondering if we can't simply rip out that single function.