Re: [PATCH v4.2 0/2] console: Add persistent scrollback buffers for all VGA console
From: Andrey Utkin
Date: Sat Nov 19 2016 - 13:26:08 EST
Got into trouble sending my replies to LKML from Mutt, getting delivery
rejections related to encoding:
Sorry for people who got excessive resends from me. For now I'm sending
this from web interface, hopefully it gets things right.
I have tested your patches with v4.8.8 kernel on Gentoo system. Just
took me a little time to figure out that what my system uses as "raw
console" is not vgacon driver, but fbcon. In order to override defaults
and get VGA console, I had to add kernel bootargs "nofb nomodeset". A
pleasant byproduct of switching to VGA console was the fact that
the earliest printouts of kernel loading stage are preserved in
scrollback so I can look at them. However, vgacon is not compatible with
usage of modern graphical modes.
So your patch really works with native VGA console. This is very nice.
Thank you for filling this long-living feature gap.
Tested-by: Andrey Utkin <andrey_utkin@xxxxxxxxxxxx>
Now would you consider implementing same feature also for fbcon? As I
see it lacks same feature. I guess it may be harder because of support
of graphics (penguins on the top of screen, direct graphical output into
framebuffer-driven console - see "links -g", "fbgs", "mplayer -vo fbdev"
and so on).
P. S. I forgot to mention in my previous code review comments that both
patches have some checkpatch issues, and it should be quite easy to
perfect the patches to make checkpatch happy even in "--strict" mode.
You can use "--fix-inplace" by the way, it may solve most of that, just
review what exactly it changes so that it doesn't garble what is right.