Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage!

From: Jiri Olsa
Date: Mon Nov 21 2016 - 07:49:24 EST


On Mon, Nov 21, 2016 at 12:31:31PM +0100, Peter Zijlstra wrote:
> On Mon, Nov 21, 2016 at 12:22:29PM +0100, Jiri Olsa wrote:
> > On Mon, Nov 21, 2016 at 10:42:27AM +0100, Peter Zijlstra wrote:
> > > On Mon, Nov 21, 2016 at 10:34:25AM +0100, Jiri Olsa wrote:
> > > > On Mon, Nov 21, 2016 at 10:28:50AM +0100, Peter Zijlstra wrote:
> > >
> > > > > I think I prefer something like the below, that only annotates the one
> > > > > RDMSR in question, instead of all of them.
> > > >
> > > > I was wondering about that, but haven't found RCU_NONIDLE
> > >
> > > Its in rcupdate.h ;-)
> >
> > it was too late in the morning.. ;-) I'm assuming you'll queue this patch.. ?
>
> Probably, I still have to make pretty the uncore patch from last week,
> and I have a PEBS patch that needs looking at :-)
>
> BTW, if you have any opinion on that PEBS register set crap, do holler
> :-)
>
> lkml.kernel.org/r/20161117171731.GV3157@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

ook, will check

thanks,
jirka