Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

[Roger Quadros]

On 21/11/16 13:56, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@xxxxxx> writes:
>> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
>> index f945380..6553903 100644
>> --- a/drivers/usb/host/xhci.h
>> +++ b/drivers/usb/host/xhci.h
>> @@ -1656,6 +1656,9 @@ struct xhci_hcd {
>>  #define XHCI_SSIC_PORT_UNUSED	(1 << 22)
>>  #define XHCI_NO_64BIT_SUPPORT	(1 << 23)
>>  #define XHCI_MISSING_CAS	(1 << 24)
>> +/* For controller with a broken Port Disable implementation */
>> +#define XHCI_BROKEN_PORT_PED	(1 << 21)
> 
> since back when I first wrote this, bit 21 has been taken. You should be
> using bit 25 here.
> 
My bad. I'll fix this up.

cheers,
-roger

Attachment: signature.asc
Description: OpenPGP digital signature