Re: [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services

From: Joe Perches
Date: Tue Nov 22 2016 - 11:52:54 EST


On Tue, 2016-11-22 at 16:40 +0000, David Howells wrote:
> Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > Umm, no, that's not correct.
> > SHA-1 lengths of 12 are unique for quite awhile yet.
> >
> > https://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/
>
> The article says:
>
> 1.9% at 12
>
> which is for 3253824 objects (I get 1.86%).
>
> However, that was three years ago, and we now have over five million objects,
> so the collision possibility is 4.5% now.
>
> If we add another 2 million over the next three years, then the probability
> will be over 8% then.
>
> I've attached my spreadsheet for you to have a look at.
>
> > No. Use --format=email as appropriate instead.
>
> Fix checkpatch. This is an entirely reasonable supposition.

No. There's nothing to fix there IMO.
Of course you are welcome to submit patches.