Re: [PATCH] misc: sram: remove useless #ifdef
From: Alexandre Belloni
Date: Tue Nov 22 2016 - 12:59:59 EST
On 22/11/2016 at 19:47:52 +0200, Vladimir Zapolskiy wrote :
> Hi Arnd,
> On 11/22/2016 04:30 PM, Arnd Bergmann wrote:
> > A recent patch added a new function that is now unused whenever
> > CONFIG_OF is disabled:
> > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]
> > There is actually no reason for the #ifdef, because the driver
> > currently cannot be used in a meaningful way without CONFIG_OF,
> > and there is no compile-time dependency.
> > Removing that #ifdef and the respective of_match_ptr() avoids the
> > warning and simplifies the driver slightly.
> > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support")
> I can not find the referenced commit on Torvald's branch,
> won't it be rebased and get a changed commit hash after merge?
No, it won't be rebased, the merge will keep the commit ID.
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering