Re: [PATCH 1/2] PM / Domains: Introduce domain-performance-state binding
From: Viresh Kumar
Date: Tue Nov 22 2016 - 22:22:30 EST
Thanks for explaining on my behalf Vincent :)
On 22-11-16, 19:34, Vincent Guittot wrote:
> On 22 November 2016 at 19:12, Kevin Hilman <khilman@xxxxxxxxxxxx> wrote:
> > I think the question is: what does the performance-level of a domain
> > actually mean? Or, what are the units?
There is no unit. If we have units like Hz and volts etc, then we can actually
use the existing clk/regulator frameworks straight away.
The whole problem here is that the regulator (and maybe the clock on a different
platform) for a power domain are hidden from the kernel and handled by a black
box (An M3 core in my case). All we can ask is for a performance state, a simple
positive integer value.
> > Depending on the SoC, there's probably a few things this could mean. It
> > might mean is that an underlying bus/interconnect can be configured to
> > guarantee a specific bandwidth or throughput.
We are talking in terms of power domains here and so if the bus/interconnect has
a power domain for itself, then yes we can very much have that situation. But if
the kernel have the capability of configuring clk and voltages directly, then we
don't need this new infrastructure at all.
> > That in turn might mean
> > that that bus/interconnect might have to be set at a specific
> > frequency/voltage.
> > In your case, IIUC, you're just passing some magic value to some
> > firmware running on a micro-controller, but under the hood that uC is
> > probably configuring a frequency/voltage someplace.
> In the case described by Viresh, it's only about setting the voltage
> of a power domain that is shared between different devices. these
> devices wants to run at different frequency (set by the devices) but
> we have to select a Volateg value that will match with the constraint
> of all devices (in this case the highest voltage)
> > So, if we're going to have a generic DT binding for this, it needs to be
> > something that's useful on platforms that are not using magic numbers
> > managed by a uC as well.
What suggestions do you have for this and I am not sure what all cases we want
to solve by this ?