Re: [PATCH v3 3/5] i2c: designware: Add slave definitions
From: Luis Oliveira
Date: Wed Nov 23 2016 - 09:43:41 EST
OK, I will create a "mode" string property in the devicetree that can be
"master" or "slave".
Thank you all,
On 18-Nov-16 17:01, Rob Herring wrote:
> On Fri, Nov 18, 2016 at 02:35:52PM +0200, Andy Shevchenko wrote:
>> On Fri, 2016-11-18 at 11:19 +0000, Luis Oliveira wrote:
>>> - Add slave defintitions to i2c-designware-core
>>> - Changes in Kconfig to auto-enable I2C_SLAVE when compiling the
>>> - Add compatible string to designware-core.txt explaining the
>>> devicetree bindings
>>> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
>>> @@ -2,7 +2,9 @@
>>> Required properties :
>>> - - compatible : should be "snps,designware-i2c"
>>> + - compatible : should be:
>>> + - "snps,designware-i2c" to setup the hardware block as I2C master.
>>> + - "snps,designware-i2c-slave" to setup the hardware block as I2C
>> Not sure about this one.
>> Compatible string is more generic than list of modes. Basically you have
>> to add a property which selects mode.
> Yes, agreed. And come up with a common property.
>> DT people's ACK is a must for this change.
>> --- a/drivers/i2c/busses/Kconfig
>>> +++ b/drivers/i2c/busses/Kconfig
>>> @@ -470,6 +470,7 @@ config I2C_DESIGNWARE_CORE
>>> config I2C_DESIGNWARE_PLATFORM
>>> tristate "Synopsys DesignWare Platform"
>>> select I2C_DESIGNWARE_CORE
>>> + select I2C_SLAVE
>> Common rule, generic dependencies usually go first
>> select I2C_SLAVE
>> select I2C_DESIGNWARE_CORE
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Intel Finland Oy