Re: [PATCH 0/6] KVM: x86: minor irqchip improvements (API change)

From: Paolo Bonzini
Date: Thu Nov 24 2016 - 11:58:51 EST




----- Original Message -----
> From: "Radim KrÄmÃÅ" <rkrcmar@xxxxxxxxxx>
> To: linux-kernel@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx
> Cc: "Paolo Bonzini" <pbonzini@xxxxxxxxxx>
> Sent: Thursday, November 24, 2016 5:31:28 PM
> Subject: [PATCH 0/6] KVM: x86: minor irqchip improvements (API change)
>
> There are two API changes:
> 1) [1/6] forbids KVM_CREATE_IRQCHIP after KVM_CAP_SPLIT_IRQCHIP
> 2) [5/6] makes KVM_SET_GSI_ROUTING reject pic and ioapic routes in split
> irqchip mode, because they make no sense and are currently "working" only
> because of a hacky NULL check.
>
> [1-4/6] are needed for [5/6]; [6/6] is just a cherry.

Looks good---but they don't apply directly on top of kvm/next so we have
to delay them until -rc2 or a second 4.11 pull request.

Anyway,

Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

> Radim KrÄmÃÅ (6):
> KVM: x86: do allow kvm irqchip with split irqchip
> KVM: x86: decouple irqchip_in_kernel() and pic_irqchip()
> KVM: x86: make pic setup code look like ioapic setup
> KVM: x86: refactor pic setup in kvm_set_routing_entry
> KVM: x86: prevent setup of invalid routes
> KVM: x86: simplify conditions with split/kvm irqchip
>
> arch/x86/include/asm/kvm_host.h | 1 +
> arch/x86/kvm/i8259.c | 16 +++++++++++-----
> arch/x86/kvm/irq.h | 17 +++++++++--------
> arch/x86/kvm/irq_comm.c | 29 ++++++++++-------------------
> arch/x86/kvm/x86.c | 39 ++++++++++++++++++++-------------------
> 5 files changed, 51 insertions(+), 51 deletions(-)
>
> --
> 2.10.2
>
>