Re: [PATCH 1/3] perf sched timehist: Mark schedule function in callchains

From: David Ahern
Date: Fri Nov 25 2016 - 22:38:26 EST


On 11/23/16 11:30 PM, Namhyung Kim wrote:
> Hi David,
>
> On Wed, Nov 23, 2016 at 10:13:46PM -0500, David Ahern wrote:
>> On 11/23/16 8:11 PM, Namhyung Kim wrote:
>>> The sched_switch event always captured from the scheduler function. So
>>> it'd be great omit them from the callchain. This patch marks the
>>> functions to be omitted by later patch.
>>
>> I had this covered by a symbol filter:
>>
>> https://github.com/dsahern/linux/blob/perf/full-monty-4.1/tools/perf/builtin-sched.c#L3000
>>
>> Not sure what happened over the years but that should still work and
>> allows the user to add more symbols to ignore:
>
> The symbol filter was removed by commit be39db9f2932 ("perf symbols:
> Remove symbol_filter_t machinery").

That's unfortunate. The exclude list is huge in removing redundant callchains and getting more relevant information on the screen with a stack depth of 5. I'll see what I can cook up with the existing code.