Re: [PATCH 4/5] regulator: Add support for TI TWL6032

From: Rosia, Nicolae
Date: Sat Nov 26 2016 - 15:24:39 EST


Hi,

On Sun, 2016-11-27 at 02:55 +0800, kbuild test robot wrote:
> Hi Nicolae,
>
> [auto build test ERROR on omap/for-next]
> [also build test ERROR on v4.9-rc6]
> [cannot apply to next-20161125]
> [if your patch is applied to the wrong git tree, please drop us a
> note to help improve the system]
>
> url:ÂÂÂÂhttps://github.com/0day-ci/linux/commits/Nicolae-Rosia/mfd-tw
> l-improvements-and-new-regulator-driver/20161127-022201
> base:ÂÂÂhttps://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-
> omap.git for-next
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> ÂÂÂÂÂÂÂÂ# save the attached .config to linux build tree
> ÂÂÂÂÂÂÂÂmake ARCH=i386Â
>
> All error/warnings (new ones prefixed by >>):
>
> ÂÂÂIn file included from drivers/regulator/twl6032-regulator.c:11:0:
> > > drivers/regulator/twl6032-regulator.c:557:31: error:
> > > 'twl6032_regulator_driver_ids' undeclared here (not in a
> > > function)
>
> ÂÂÂÂMODULE_DEVICE_TABLE(platform, twl6032_regulator_driver_ids);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> ÂÂÂinclude/linux/module.h:213:21: note: in definition of macro
> 'MODULE_DEVICE_TABLE'
> ÂÂÂÂextern const typeof(name)
> __mod_##type##__##name##_device_tableÂÂ\
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^~~~
> > > include/linux/module.h:213:27: error:
> > > '__mod_platform__twl6032_regulator_driver_ids_device_table'
> > > aliased to undefined symbol 'twl6032_regulator_driver_ids'
>
> ÂÂÂÂextern const typeof(name)
> __mod_##type##__##name##_device_tableÂÂ\
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^
> > > drivers/regulator/twl6032-regulator.c:557:1: note: in expansion
> > > of macro 'MODULE_DEVICE_TABLE'
>
> ÂÂÂÂMODULE_DEVICE_TABLE(platform, twl6032_regulator_driver_ids);
> ÂÂÂÂ^~~~~~~~~~~~~~~~~~~
>
> vim +/twl6032_regulator_driver_ids +557 drivers/regulator/twl6032-
> regulator.c
>
> ÂÂÂ551
> ÂÂÂ552 static const struct of_device_id twl6032_dt_match[] = {
> ÂÂÂ553 { .compatible = "ti,twl6032-regulator" },
> ÂÂÂ554 { /* last entry */ }
> ÂÂÂ555 };
> ÂÂÂ556
> Â> 557 MODULE_DEVICE_TABLE(platform,
> twl6032_regulator_driver_ids);
> ÂÂÂ558
> ÂÂÂ559 static struct platform_driver twl6032_regulator_driver
> = {
> ÂÂÂ560 .driver = {

Thanks, I did not notice this since I was only testing using built-in
module.
I will wait for comments before sending V2, untill then here's an
inline patch with the fix.


Best regards,
Nicolae