Re: [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc pins

From: Sekhar Nori
Date: Mon Nov 28 2016 - 03:15:16 EST


On Thursday 24 November 2016 08:34 PM, Axel Haslam wrote:
> Currently the mmc driver is polling the gpio to know if the
> card was removed.
>
> By using a gpio descriptor instead of the platform callbacks,
> the driver will be able to register the gpio using the mmc core
> API's designed for this purpose.

s/API's/APIs

>
> This has the advantage that an irq will be registered, and
> polling is no longer needed. Also, a dependency on platform
> callbacks is removed for this board.
>
> Signed-off-by: Axel Haslam <ahaslam@xxxxxxxxxxxx>
> ---
> arch/arm/mach-davinci/board-omapl138-hawk.c | 42 ++++++++---------------------
> 1 file changed, 11 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
> index a4e8726..a2966d3 100644
> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> @@ -15,6 +15,7 @@
> #include <linux/gpio.h>
> #include <linux/platform_data/gpio-davinci.h>
> #include <linux/regulator/machine.h>
> +#include <linux/gpio/machine.h>

Moved this include to below linux/gpio.h

Applied to v4.10/soc

Thanks,
Sekhar