Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning
From: Paul E. McKenney
Date: Mon Nov 28 2016 - 09:39:37 EST
On Fri, Nov 25, 2016 at 07:52:23PM -0500, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> Date: Wed, 23 Nov 2016 22:48:19 +0200
> > I would appreciate review to confirm the function doesn't
> > do anything unsafe though.
> > In particular, should this use __hlist_for_each_rcu instead?
> > I note that __hlist_for_each_rcu does rcu_dereference
> > internally, which is missing here.
> I personally think it should use __hlist_for_each_rcu, otherwise
> nothing expresses the rcu-ness of the operation.
I like Dave's suggestion. Michael, does that change work for you?