Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold
From: Shaohua Li
Date: Mon Nov 28 2016 - 17:14:43 EST
On Mon, Nov 28, 2016 at 05:08:18PM -0500, Tejun Heo wrote:
> Hello, Shaohua.
> On Wed, Nov 23, 2016 at 05:06:30PM -0800, Shaohua Li wrote:
> > > Shouldn't this be a per-cgroup setting along with latency target?
> > > These two are the parameters which define how the cgroup should be
> > > treated time-wise.
> > It should be easy to make it per-cgroup. Just not sure if it should be
> > per-cgroup. The logic is if the disk is faster, wait time should be shorter to
> > not harm performance. So it sounds like a per-disk characteristic.
> Yes, this is something dependent on the device, but also on the
> workload. For both this parameter and the latency target, it seems
> that they should be specified along with the actual device limits so
> that they follow the same convention and can be specified per cgroup *
> block device. What do you think?
That's ok, I'm totally fine to make it per cgroup and per disk.