Re: [PATCH v2 06/12] mm: thp: enable thp migration in generic path

From: Naoya Horiguchi
Date: Tue Nov 29 2016 - 03:21:58 EST


On Mon, Nov 28, 2016 at 03:33:32PM +0100, Michal Hocko wrote:
> On Tue 08-11-16 08:31:51, Naoya Horiguchi wrote:
> > This patch makes it possible to support thp migration gradually. If you fail
> > to allocate a destination page as a thp, you just split the source thp as we
> > do now, and then enter the normal page migration. If you succeed to allocate
> > destination thp, you enter thp migration. Subsequent patches actually enable
> > thp migration for each caller of page migration by allowing its get_new_page()
> > callback to allocate thps.
>
> Does this need to be in a separate patch? Wouldn't it make more sense to
> have the full THP migration code in a single one?

Actually, no big reason for separate patch. So I'm OK to merge this into
patch 5/12.

Thanks,
Naoya Horiguchi