Re: [PATCH 0/9] Get rid of bitmap images

From: Mauro Carvalho Chehab
Date: Wed Nov 30 2016 - 04:29:56 EST


Em Mon, 28 Nov 2016 18:09:46 -0700
Jonathan Corbet <corbet@xxxxxxx> escreveu:

> On Sun, 20 Nov 2016 14:08:31 -0200
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> wrote:
>
> > The goal of this patch series is to get rid of PNG images, using either graphviz
> > or SVG for images.
>
> So the pdfdocs build fails with an error when I apply this...
>
> > xelatex -interaction=batchmode 'media.tex'
> > This is XeTeX, Version 3.14159265-2.6-0.99993 (TeX Live 2016/dev) (preloaded format=xelatex)
> > restricted \write18 enabled.
> > entering extended mode
> > Makefile:58: recipe for target 'media.pdf' failed
> > make[2]: *** [media.pdf] Error 1
> > Documentation/Makefile.sphinx:83: recipe for target 'pdfdocs' failed
> > make[1]: *** [pdfdocs] Error 2
> > Makefile:1442: recipe for target 'pdfdocs' failed
> > make: *** [pdfdocs] Error 2
>
> There's nothing more useful than that in the log as far as I can tell.

> I take it you don't see this?

No, I didn't see.

Calling it in interactive mode with:

$ make -C Documentation/output/latex/ media.pdf PDFLATEX=xelatex

allowed to identify the issue. The problem is that I forgot to
change the file extension from .svg to .* on one of the figure includes.

The enclosed patch fixes it.

I'll fold it with the patch that converted and send a new version
of this patch series.

Thanks for noticing it!
Mauro


diff --git a/Documentation/media/uapi/v4l/field-order.rst b/Documentation/media/uapi/v4l/field-order.rst
index 27fccd3cb9b4..e05fb1041363 100644
--- a/Documentation/media/uapi/v4l/field-order.rst
+++ b/Documentation/media/uapi/v4l/field-order.rst
@@ -151,7 +151,7 @@ Field Order, Top Field First Transmitted
Field Order, Bottom Field First Transmitted
===========================================

-.. figure:: fieldseq_bt.svg
+.. figure:: fieldseq_bt.*
:alt: fieldseq_bt.pdf / fieldseq_bt.svg
:align: center