Re: [PATCH 4/6] ubifs: Maintain a parent pointer

From: Richard Weinberger
Date: Fri Dec 02 2016 - 05:36:48 EST


On 02.12.2016 10:28, Marcus Folkesson wrote:
> On Thu, Dec 01, 2016 at 11:02:19PM +0100, Richard Weinberger wrote:
>>
>> + if (new_dir != old_dir) {
>> + fst_inode_ui->parent_inum = new_dir->i_ino;
>> + snd_inode_ui->parent_inum = old_dir->i_ino;
>> + }
>> +
>> if (old_dir != new_dir) {
>> if (S_ISDIR(fst_inode->i_mode) && !S_ISDIR(snd_inode->i_mode)) {
>> inc_nlink(new_dir);
>
> Insignificant thing, but use the existing if-statment instead?

Of course.
I moved the line around and oversaw the existing branch. :)

Thanks,
//richard