Re: [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation

[Linus Torvalds]

On Fri, Dec 2, 2016 at 11:30 AM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>
> How's this?

Looks ok. I do think that

> I suppose it could be an unconditional IRET-to-self, but that's a good
> deal slower and not a whole lot simpler.  Although if we start doing
> it right, performance won't really matter here.

Considering you already got the iret-to-self wrong in the first
version, I really like the "one single unconditional version" so that
everybody tests that _one_ thing and there isn't anything subtle going
on.

Hmm?

And yes, if it turns out that performance matters, we almost certainly
are doing something really wrong, and we shouldn't be using that
sync_core() thing in that place anyway.

                 Linus