Re: [PATCH 1/1] net: bnx2x: fix improper return value

[Sergei Shtylyov]

On 12/4/2016 11:39 AM, Pan Bian wrote:

> From: Pan Bian <bianpan2016@xxxxxxx>
>
> Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate

   Macro.

> memory, and jumps to label "lbl" if the allocation fails. Label "lbl"
> first cleans memory and then returns variable rc. Before calling the
> macro, the value of variable rc is 0. Because 0 means no error, the
> callers of bnx2x_init_firmware() may be misled. This patch fixes the bug,
> assigning "-ENOMEM" to rc before calling macro NX2X_ALLOC_AND_SET().
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189141
>
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
[...]

MBR, Sergei