Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

From: Lino Sanfilippo
Date: Mon Dec 05 2016 - 06:40:17 EST


Hi,

>
> Actually, I was wrong. irqlock protection is needed, since
> stmmac_tx_clean() is called from timer, and that's interrupt context,
> as you can confirm using BUG_ON(in_interrupt());
>

in_interrupt() can mean both softirq and hardirq context. In this case it
means softirq. So I guess you were right before, and no irq locking is needed.

Regards,
Lino