RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

From: Salil Mehta
Date: Mon Dec 05 2016 - 10:42:58 EST


> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Saturday, December 03, 2016 8:25 PM
> To: Salil Mehta
> Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@xxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm
> Subject: Re: [PATCH V2 net-next] net: hns: Fix to conditionally convey
> RX checksum flag to stack
>
> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Date: Thu, 1 Dec 2016 16:59:14 +0000
>
> > It looks to me the cumbersome check in the PATCH V2 should
> > be retained.
>
> I really want something simpler with small checks that are
> done in logical pieces in a straigtforward progression.
>
> The code in V2 is completely unreadable.
Hi David,
I understand your concern. I have floated the Patch V3 with
re-structured code for your review. Thanks!

Best regards
Salil