Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

From: Dan Carpenter
Date: Mon Dec 05 2016 - 15:52:03 EST


On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote:
> For the first lines of the patch, I opted to create a small function
> instead of breaking the the line in a weird way.

These first ones are the nice.

> @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
> if (ch->ch_tun.un_flags & (UN_LOW | UN_EMPTY)) {
> ch->ch_tun.un_flags &=
> ~(UN_LOW | UN_EMPTY);
> - wake_up_interruptible(&ch->ch_tun.un_flags_wait);
> + wake_up_interruptible(&ch->ch_tun
> + .un_flags_wait);


Ugh... No. Don't do this. Just let it go over 80 characters. Ignore
the warning.

regards,
dan carpenter