Re: [PATCH 1/3] ARM: dts: imx6: Add Savageboard common file

[Milo Kim]

On 12/05/2016 08:36 PM, Fabio Estevam wrote:
> On Sun, Dec 4, 2016 at 11:07 PM, Milo Kim <woogyom.kim@xxxxxxxxx> wrote:
>
> > +       regulators {
> > +               compatible = "simple-bus";
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               reg_3p3v: regulator@0 {
> > +                       compatible = "regulator-fixed";
> > +                       reg = <0>;
> > +                       regulator-name = "3P3V";
> > +                       regulator-min-microvolt = <3300000>;
> > +                       regulator-max-microvolt = <3300000>;
> > +                       regulator-always-on;
> > +               };
>
> Please remove the regulators container and put the regulator node
> directly as follows:
>
> reg_3p3v: regulator-3p3v {
>    compatible = "regulator-fixed";
>    regulator-name = "3P3V";
>    regulator-min-microvolt = <3300000>;
>    regulator-max-microvolt = <3300000>;
>    regulator-always-on;
> }
>
> > +       };
> > +};
> > +
> > +&clks {
> > +       assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
> > +                         <&clks IMX6QDL_CLK_LDB_DI1_SEL>;
> > +       assigned-clock-parents = <&clks IMX6QDL_CLK_PLL3_USB_OTG>,
> > +                                <&clks IMX6QDL_CLK_PLL3_USB_OTG>;
> > +};
> > +
> > +&fec {
> > +       phy-mode = "rgmii";
> > +       phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
>
> I think you meant
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>
> > +&iomuxc {
> > +       savageboard {
> > +               pinctrl_emmc: emmcgrp {
> > +                       fsl,pins = <
> > +                               MX6QDL_PAD_SD4_CMD__SD4_CMD             0x17059
> > +                               MX6QDL_PAD_SD4_CLK__SD4_CLK             0x10059
> > +                               MX6QDL_PAD_SD4_DAT0__SD4_DATA0          0x17059
> > +                               MX6QDL_PAD_SD4_DAT1__SD4_DATA1          0x17059
> > +                               MX6QDL_PAD_SD4_DAT2__SD4_DATA2          0x17059
> > +                               MX6QDL_PAD_SD4_DAT3__SD4_DATA3          0x17059
> > +                               MX6QDL_PAD_SD4_DAT4__SD4_DATA4          0x17059
> > +                               MX6QDL_PAD_SD4_DAT5__SD4_DATA5          0x17059
> > +                               MX6QDL_PAD_SD4_DAT6__SD4_DATA6          0x17059
> > +                               MX6QDL_PAD_SD4_DAT7__SD4_DATA7          0x17059
> > +                       >;
> > +               };
>
> You can remove the savegeboard level. Please check
> arch/arm/boot/dts/imx6q-tbs2910.dts.
>
> iomux usually go as the last node of the dts file.

Thanks a lot for all your feedback. I just submitted the v2.

Best regards,
Milo