RE: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree

[Matthew Wilcox]

From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx]
> On Mon, 28 Nov 2016 13:50:37 -0800 Matthew Wilcox
> <mawilcox@xxxxxxxxxxxxxxxxx> wrote:
> >  include/linux/idr.h                     |  132 ++--
> >  include/linux/radix-tree.h              |    5 +-
> >  init/main.c                             |    3 +-
> >  lib/idr.c                               | 1078 -------------------------------
> >  lib/radix-tree.c                        |  632 ++++++++++++++++--
> 
> hm.  It's just a cosmetic issue, but perhaps the idr
> wrappers-around-radix-tree code should be in a different .c file.

I can put some of them back into idr.c -- there's a couple of routines left in there still, so adding some more won't hurt.

> Before:
> 
> akpm3:/usr/src/25> size lib/idr.o lib/radix-tree.o
>    text    data     bss     dec     hex filename
>    6566      89      16    6671    1a0f lib/idr.o
>   11811     117       8   11936    2ea0 lib/radix-tree.o
> 
> After:
> 
>    text    data     bss     dec     hex filename
>   14151     118       8   14277    37c5 lib/radix-tree.o
> 
> 
> So 4500 bytes saved.  Decent.

Not bad.  0day has been sending me email telling me that I saved something more like 1500 bytes, but that's on a minimal config.  (also a couple of routines stayed in idr.c, so you're overstating how much I saved)