Re: [GIT PULL 00/10] perf/core improvements and fixes

From: Ingo Molnar
Date: Wed Dec 07 2016 - 13:17:54 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Hi Ingo,
>
> Please consider pulling, should get linux-next free of perf build fixdep
> related race conditions on high core count machines,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 34c4a42791bbc455e65a15d12dcd0b6b3c52ad13:
>
> Merge tag 'perf-core-for-mingo-20161205' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-12-06 09:14:56 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161207
>
> for you to fetch changes up to 108a7c103b761309ccbd997002e8428808cf1e04:
>
> perf tools: Explicitly document that --children is enabled by default (2016-12-07 12:00:35 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> Improvements:
>
> - Improve error message when analyzing file with required events in
> 'perf sched timehist' (David Ahern)
>
> Fixes:
>
> - Force fixdep compilation to be done at the start of the build, fixing
> some build race conditions in high core count machines (Jiri Olsa)
>
> - Fix handling a zero sample->tid in 'perf sched timehist', as
> sometimes that isn't the idle thread (Namhyung Kim)
>
> Infrastructure:
>
> - Check minimal accepted LLVM version in its feature check, 3.9 at this
> time (Wang Nan)
>
> Documentation:
>
> - Explicitly document that --children is enabled by default (Yannick Brosseau)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> ----------------------------------------------------------------
> David Ahern (1):
> perf sched timehist: Improve error message when analyzing wrong file
>
> Jiri Olsa (3):
> perf tools: Move PERF-VERSION-FILE target into rules area
> perf tools: Force fixdep compilation at the start of the build
> perf tools: Move perf build related variables under non fixdep leg
>
> Namhyung Kim (4):
> perf sched: Cleanup option processing
> perf callchain: Introduce callchain_cursor__copy()
> perf sched timehist: Handle zero sample->tid properly
> perf sched timehist: Cleanup idle_max_cpu handling
>
> Wang Nan (1):
> perf build: Check LLVM version in feature check
>
> Yannick Brosseau (1):
> perf tools: Explicitly document that --children is enabled by default
>
> tools/build/feature/Makefile | 8 +++-
> tools/build/feature/test-llvm-version.cpp | 11 +++++
> tools/build/feature/test-llvm.cpp | 5 +++
> tools/perf/Documentation/perf-report.txt | 3 +-
> tools/perf/Documentation/perf-top.txt | 1 +
> tools/perf/Makefile.config | 8 +++-
> tools/perf/Makefile.perf | 68 +++++++++++++++++++++----------
> tools/perf/builtin-sched.c | 26 ++++++------
> tools/perf/util/callchain.c | 27 ++++++++++++
> tools/perf/util/callchain.h | 3 ++
> 10 files changed, 122 insertions(+), 38 deletions(-)
> create mode 100644 tools/build/feature/test-llvm-version.cpp
>
> # uname -a
> Linux jouet 4.8.8-300.fc25.x86_64 #1 SMP Tue Nov 15 18:10:06 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
> # perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: Detect openat syscall event : Ok
> 3: Detect openat syscall event on all cpus : Ok
> 4: Read samples using the mmap interface : Ok
> 5: Parse event definition strings : Ok
> 6: PERF_RECORD_* events & perf_sample fields : Ok
> 7: Parse perf pmu format : Ok
> 8: DSO data read : Ok
> 9: DSO data cache : Ok
> 10: DSO data reopen : Ok
> 11: Roundtrip evsel->name : Ok
> 12: Parse sched tracepoints fields : Ok
> 13: syscalls:sys_enter_openat event fields : Ok
> 14: Setup struct perf_event_attr : Ok
> 15: Match and link multiple hists : Ok
> 16: 'import perf' in python : Ok
> 17: Breakpoint overflow signal handler : Ok
> 18: Breakpoint overflow sampling : Ok
> 19: Number of exit events of a simple workload : Ok
> 20: Software clock events period values : Ok
> 21: Object code reading : Ok
> 22: Sample parsing : Ok
> 23: Use a dummy software event to keep tracking: Ok
> 24: Parse with no sample_id_all bit set : Ok
> 25: Filter hist entries : Ok
> 26: Lookup mmap thread : Ok
> 27: Share thread mg : Ok
> 28: Sort output of hist entries : Ok
> 29: Cumulate child hist entries : Ok
> 30: Track with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: kmod_path__parse : Ok
> 34: Thread map : Ok
> 35: LLVM search and compile :
> 35.1: Basic BPF llvm compile : Ok
> 35.2: kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation: Ok
> 35.4: Compile source for BPF relocation : Ok
> 36: Session topology : Ok
> 37: BPF filter :
> 37.1: Basic BPF filtering : Ok
> 37.2: BPF prologue generation : Ok
> 37.3: BPF relocation checker : Ok
> 38: Synthesize thread map : Ok
> 39: Synthesize cpu map : Ok
> 40: Synthesize stat config : Ok
> 41: Synthesize stat : Ok
> 42: Synthesize stat round : Ok
> 43: Synthesize attr update : Ok
> 44: Event times : Ok
> 45: Read backward ring buffer : Ok
> 46: Print cpu map : Ok
> 47: Probe SDT events : Ok
> 48: is_printable_array : Ok
> 49: Print bitmap : Ok
> 50: perf hooks : Ok
> 51: builtin clang support :
> 51.1: builtin clang compile C source to IR : Ok
> 51.2: builtin clang compile C source to ELF object: Ok
> 52: x86 rdpmc : Ok
> 53: Convert perf time to TSC : Ok
> 54: DWARF unwind : Ok
> 55: x86 instruction decoder - new instructions : Ok
> 56: Intel cqm nmi context read : Skip
> #
> # uname -a
> Linux zoo 4.7.3-200.fc24.x86_64 #1 SMP Wed Sep 7 17:31:21 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
> # time dm
> 1 alpine:3.4: Ok
> 2 android-ndk:r12b-arm: Ok
> 3 archlinux:latest: Ok
> 4 centos:5: Ok
> 5 centos:6: Ok
> 6 centos:7: Ok
> 7 debian:7: Ok
> 8 debian:8: Ok
> 9 debian:experimental: Ok
> 10 fedora:20: Ok
> 11 fedora:21: Ok
> 12 fedora:22: Ok
> 13 fedora:23: Ok
> 14 fedora:24: Ok
> 15 fedora:24-x-ARC-uClibc: Ok
> 16 fedora:rawhide: Ok
> 17 mageia:5: Ok
> 18 opensuse:13.2: Ok
> 19 opensuse:42.1: Ok
> 20 opensuse:tumbleweed: Ok
> 21 ubuntu:12.04.5: Ok
> 22 ubuntu:14.04: Ok
> 23 ubuntu:14.04.4: Ok
> 24 ubuntu:15.10: Ok
> 25 ubuntu:16.04: Ok
> 26 ubuntu:16.04-x-arm: Ok
> 27 ubuntu:16.04-x-arm64: Ok
> 28 ubuntu:16.04-x-powerpc: Ok
> 29 ubuntu:16.04-x-powerpc64: Ok
> 30 ubuntu:16.04-x-powerpc64el: Ok
> 31 ubuntu:16.04-x-s390: Ok
> 32 ubuntu:16.10: Ok
> #
> $ make -C tools/perf build-test
> make: Entering directory '/home/acme/git/linux/tools/perf'
> - tarpkg: ./tests/perf-targz-src-pkg .
> make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> make_help_O: make help
> make_install_prefix_slash_O: make install prefix=/tmp/krava/
> make_install_O: make install
> make_static_O: make LDFLAGS=-static
> make_no_libbionic_O: make NO_LIBBIONIC=1
> make_no_backtrace_O: make NO_BACKTRACE=1
> make_no_libunwind_O: make NO_LIBUNWIND=1
> make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
> make_doc_O: make doc
> make_no_libbpf_O: make NO_LIBBPF=1
> make_util_map_o_O: make util/map.o
> make_install_bin_O: make install-bin
> make_no_auxtrace_O: make NO_AUXTRACE=1
> make_with_babeltrace_O: make LIBBABELTRACE=1
> make_with_clangllvm_O: make LIBCLANGLLVM=1
> make_debug_O: make DEBUG=1
> make_no_libelf_O: make NO_LIBELF=1
> make_clean_all_O: make clean all
> make_no_libperl_O: make NO_LIBPERL=1
> make_no_libaudit_O: make NO_LIBAUDIT=1
> make_no_slang_O: make NO_SLANG=1
> make_util_pmu_bison_o_O: make util/pmu-bison.o
> make_no_gtk2_O: make NO_GTK2=1
> make_pure_O: make
> make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
> make_install_prefix_O: make install prefix=/tmp/krava
> make_tags_O: make tags
> make_no_demangle_O: make NO_DEMANGLE=1
> make_perf_o_O: make perf.o
> make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
> make_no_libnuma_O: make NO_LIBNUMA=1
> make_no_libpython_O: make NO_LIBPYTHON=1
> make_no_newt_O: make NO_NEWT=1
> OK
> make: Leaving directory '/home/acme/git/linux/tools/perf'
> $

Pulled, thanks a lot Arnaldo!

Ingo