Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type

From: James Simmons
Date: Wed Dec 07 2016 - 19:16:55 EST



> As per interval_search() prototype, the callback should return
> enum, not int.
> This fixes correspondign sparse warning.
>
> Signed-off-by: Oleg Drokin <green@xxxxxxxxxxxxxx>

Reviewed-by: James Simmons <jsimmons@xxxxxxxxxxxxx>

> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index a4a291a..f4cbc89 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1148,7 +1148,7 @@ static int lock_matches(struct ldlm_lock *lock, struct lock_match_data *data)
> return INTERVAL_ITER_STOP;
> }
>
> -static unsigned int itree_overlap_cb(struct interval_node *in, void *args)
> +static enum interval_iter itree_overlap_cb(struct interval_node *in, void *args)
> {
> struct ldlm_interval *node = to_ldlm_interval(in);
> struct lock_match_data *data = args;
> --
> 2.7.4
>
>