Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions
From: Greg Kroah-Hartman
Date: Thu Dec 08 2016 - 08:30:36 EST
On Thu, Dec 08, 2016 at 12:30:20PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 8 Dec 2016 11:37:37 +0100
> Some update suggestions were taken into account
> from static source code analysis.
> Markus Elfring (5):
> Combine four kcalloc() calls into one in serial2002_setup_subdevs()
> Split a condition check in usbdux_alloc_usb_buffers()
> Move an assignment in usbdux_alloc_usb_buffers()
> Split a condition check in usbduxsigma_alloc_usb_buffers()
> Move an assignment in usbduxsigma_alloc_usb_buffers()
> drivers/staging/comedi/drivers/serial2002.c | 22 +++++-----
> drivers/staging/comedi/drivers/usbdux.c | 56 ++++++++++++++++++-----
> drivers/staging/comedi/drivers/usbduxsigma.c | 66 ++++++++++++++++++++++------
> 3 files changed, 108 insertions(+), 36 deletions(-)
You do realize that I no longer take patches from you for any of the
subsystems I maintain, right? This patch series is one reason why...
I suggest working on other projects to learn C better first.
best of luck,