Re: [PATCH 06/20] hwmon/via-cputemp: Convert to hotplug state machine
From: Guenter Roeck
Date: Fri Dec 09 2016 - 13:17:44 EST
On Fri, Dec 09, 2016 at 12:53:30PM +0100, Thomas Gleixner wrote:
> On Thu, 17 Nov 2016, Sebastian Andrzej Siewior wrote:
> > Install the callbacks via the state machine and let the core invoke the
> > callbacks on the already online CPUs. When the hotplug state is
> > unregistered the cleanup function is called for each cpu. So both cpu loops
> > in init() and exit() are not longer required.
> Can we please get those two VIA patches merged for 4.10? They are blocking
> the final removal of the CPU hotplug notifier crap.
> The first one which removes that loop is really harmless as there are no
> multisocket VIAs. Heterogenous cores in a single die would be surprising
> and the loop check would be the least of our worries in that case. IOW, it
> would never get so far...
I had queued that one already.
> The one converting the notifier is not changing any of the functionality.
> I cannot test on all VIA SMP variants either, but at least on the one I
> have access to it just works.
I queued up the second patch as well. Hope it does not blow up on us.
Sorry, I got a bit nervous after the coretemp experience.