Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t

From: Saeed Mahameed
Date: Fri Dec 09 2016 - 16:21:02 EST




On 12/08/2016 11:57 PM, Arnd Bergmann wrote:
> On 32-bit ARM with 64-bit dma_addr_t I get this warning about an
> incorrect format string:
>
> In file included from /git/arm-soc/drivers/net/ethernet/mellanox/mlx5/core/alloc.c:42:0:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c: In function âmlx5_frag_buf_alloc_nodeâ:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c:134:12: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> We have the special %pad format for printing dma_addr_t, so use that
> to print the correct address and avoid the warning.
>
> Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thank you Arnd !!

Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>