Should xhci_irq() call usb_hc_died()?

From: Bjorn Helgaas
Date: Fri Dec 09 2016 - 19:26:25 EST


Hi Mathias,

ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code
equivalent to this:

status = ehci_readl(...);
if (status == ~(u32) 0) {
...
usb_hc_died(hcd);
...
return IRQ_HANDLED;
}

xhci_irq() has a similar check, but does not call usb_hc_died():

status = readl(...);
if (status = 0xffffffff) {
...
return IRQ_HANDLED;
}

Should xhci_irq() also call usb_hc_died()? Maybe there's some reason
for it to be different than the others, but it wasn't obvious to this
casual observer :)

Bjorn