Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver

From: Wolfram Sang
Date: Sun Dec 11 2016 - 16:42:41 EST


> +config I2C_STM32F4
> + tristate "STMicroelectronics STM32F4 I2C support"
> + depends on ARCH_STM32 || COMPILE_TEST

Double space.

> +#define STM32F4_I2C_MIN_FREQ 2
> +#define STM32F4_I2C_MAX_FREQ 42

Those two must be unsigned to fix the build error (e.g. 2U) reported by

Also, I get the following build warnings:

CC drivers/i2c/busses/i2c-stm32f4.o
drivers/i2c/busses/i2c-stm32f4.c: In function âstm32f4_i2c_handle_rx_addrâ:
drivers/i2c/busses/i2c-stm32f4.c:445:6: warning: variable âsr2â set but not used [-Wunused-but-set-variable]
u32 sr2;
drivers/i2c/busses/i2c-stm32f4.c: In function âstm32f4_i2c_isr_eventâ:
drivers/i2c/busses/i2c-stm32f4.c:496:41: warning: variable âsr2â set but not used [-Wunused-but-set-variable]
u32 real_status, possible_status, ien, sr2;

I assume those are reads to clear the register, so we really don't need
to save the value in a variable.

Rest is looking good.



Attachment: signature.asc
Description: PGP signature