Re: [media] bt8xx: One function call less in bttv_input_init() after error detection
From: Daniele Nicolodi
Date: Sun Dec 11 2016 - 16:52:52 EST
On 10/12/16 15:10, SF Markus Elfring wrote:
>> Despite that, you have found several instances of similar constructs:
> Yes. - Special source code search pattern can point such places out
> for further considerations.
This is one of the things that makes reviewing the patches you submit
quire annoying: if a class of changes has already been turned town, why
do you insist in proposing it?
>> Didn't it occur to you that maybe those constructs are fine the way
>> they are and this is the idiomatic way to write that kind of code?
> Such a programming approach might look convenient. - I would prefer
> a safer coding style for the corresponding exception handling.
Can you please point out what is wrong in the current code and how the
changes you propose fix the problem? Clearly the people reading your
patches do not see the problem you are seeing.
>> Why are you submitting patches implementing changes that have already
>> been rejected?
> The feedback to my update mixture is varying between acceptance and
> disagreements as usual.
No one has expressed acceptance for the kind of change you propose with
this patch, or to previous patches you proposed changing similar constructs.
>> Judging from your recent submissions, it seems that this process is not
>> working well for you. I'm probably not the only one that is wonderign
>> what are you trying to obtain with your patch submissions, other than
>> having your name in the git log.
> I am picking some change possibilities up in the hope of related
> software improvements.
The fact that you propose over and over again a class of changes that
has been already vocally rejected would suggest otherwise. The major
achievement you obtained so far is that one of the maintainers of a
large fraction of the kernel refuses to look at your patch submissions.
Maybe you should revise how you contribute to Linux kernel development.
Apparently ignoring comments to your previous patch submission and not
showing that you have been learning from previous interactions, is not
going to help.