Re: [PATCH 08/10] vsock/virtio: mark an internal function static

[Jason Wang]

On 2016å12æ08æ 22:25, Michael S. Tsirkin wrote:
> On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
> > On 2016å12æ06æ 23:41, Michael S. Tsirkin wrote:
> > > virtio_transport_alloc_pkt is only used locally, make it static.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > > ---
> > >    net/vmw_vsock/virtio_transport_common.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> > > index a53b3a1..6120384 100644
> > > --- a/net/vmw_vsock/virtio_transport_common.c
> > > +++ b/net/vmw_vsock/virtio_transport_common.c
> > > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void)
> > >    	return container_of(t, struct virtio_transport, transport);
> > >    }
> > > -struct virtio_vsock_pkt *
> > > +static struct virtio_vsock_pkt *
> > >    virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info,
> > >    			   size_t len,
> > >    			   u32 src_cid,
> > Git grep shows it was used by tracing.
> True but trace_virtio_transport_alloc_pkt is also local to
> virtio_transport_common.c

I see, so let's remove the EXPORT_SYMBOL_GPL() too?