Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages

From: Caesar Wang
Date: Mon Dec 12 2016 - 05:48:07 EST

å 2016å11æ30æ 13:04, Eduardo Valentin åé:

On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:


+ __func__, table.mode);
Given that we are improving messages, would it be more informative to
say that you have an invalid table mode?
I considered the mode and ID listing to go hand in hand, so it was the
whole table that is wrong. But it is just as well to say the "table
mode" is wrong.

Maybe even better: "%s: unknown table mode: %d\n".

Yup, that works for me, even better.

Done. Sorry for delay.

And I guess same answer for patch 4, where you had the same question.


+ return -EINVAL;
Linux-rockchip mailing list