Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

From: Gary R Hook
Date: Mon Dec 12 2016 - 17:19:08 EST

On 12/12/2016 12:34 PM, Andy Lutomirski wrote:


I have a patch to make these depend on !VMAP_STACK.


According to Herbert, these are fine. I'm personally less convinced
since I'm very confused as to what "async" means in the crypto code,
but I'm going to leave these alone.

I went back through the code, and AFAICT every argument to sg_init_one() in
the above-cited files is a buffer that is part of the request context. Which
is allocated by the crypto framework, and therefore will never be on the stack.

I don't (as yet) see a need for any patch to these. Someone correct me if I'm
missing something.


This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer